Add arbitrary fill value support #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavrospapadopoulos
force-pushed
the
sp/default_values
branch
2 times, most recently
from
9ab9f5f to
72f72a7
Compare
…values are used when empty attribute values are retrieved during a read query. This can happen either (1) in the case of a dense array with "empty" regions, or (2) any array with missing attributes. Note that the latter (i.e., enabling writes with a subset of attributes) will be supported in a subsequent PR.
stavrospapadopoulos
force-pushed
the
sp/default_values
branch
from
72f72a7 to
1849822
Compare
Shelnutt2
reviewed
Jun 8, 2020
Shelnutt2
approved these changes
Jun 8, 2020
joe-maley
approved these changes
Jun 8, 2020
|
Mentioned this on TileDB/TileDB-Java#177. The current inconsistent defaults in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the user to set arbitrary fill values to attributes. The fill values are used when empty attribute values are retrieved during a read query. This can happen either (1) in the case of a dense array with "empty" regions, or (2) any array with missing attributes. Note that the latter (i.e., enabling writes with a subset of attributes) will be supported in a subsequent PR.
Breaking behavior: Now reading completely empty dense arrays will return fill values, whereas before it was returning zero results.