Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User can set separate coordinate buffers upon reads #1547

Merged
merged 1 commit into from
Mar 18, 2020
Merged

User can set separate coordinate buffers upon reads #1547

merged 1 commit into from
Mar 18, 2020

Conversation

stavrospapadopoulos
Copy link
Member

Towards addressing #93

@stavrospapadopoulos stavrospapadopoulos added this to the 1.8.0 milestone Mar 15, 2020
@stavrospapadopoulos stavrospapadopoulos force-pushed the sp/sep_read_buffs branch 3 times, most recently from ff009eb to 1958371 Compare March 17, 2020 22:37
joe-maley
joe-maley approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@joe-maley joe-maley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments that you can address in the next patch if you don't wanna re-run CI.

tiledb/sm/array/array.cc Show resolved Hide resolved
tiledb/sm/array_schema/array_schema.cc Show resolved Hide resolved
tiledb/sm/misc/types.h Show resolved Hide resolved
tiledb/sm/query/reader.cc Show resolved Hide resolved
tiledb/sm/query/reader.cc Show resolved Hide resolved
tiledb/sm/query/reader.h Outdated Show resolved Hide resolved
@stavrospapadopoulos stavrospapadopoulos merged commit 3825b6a into dev Mar 18, 2020
@stavrospapadopoulos stavrospapadopoulos deleted the sp/sep_read_buffs branch March 18, 2020 18:20
@stavrospapadopoulos stavrospapadopoulos mentioned this pull request Mar 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-maley joe-maley joe-maley approved these changes

Assignees
No one assigned
Labels
internals refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stavrospapadopoulos @joe-maley