Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader now works without zipping the coordinates #1481

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Reader now works without zipping the coordinates #1481

merged 1 commit into from
Jan 22, 2020

Conversation

stavrospapadopoulos
Copy link
Member

This is towards addressing #93. Also several cleanups.

@stavrospapadopoulos stavrospapadopoulos added this to the 1.8.0 milestone Jan 17, 2020
joe-maley
joe-maley approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@joe-maley joe-maley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All my comments were nit-picks.

@stavrospapadopoulos stavrospapadopoulos merged commit 2014c75 into dev Jan 22, 2020
@stavrospapadopoulos stavrospapadopoulos mentioned this pull request Mar 21, 2020
Closed
@Shelnutt2 Shelnutt2 deleted the sp/split_coords_reader branch June 8, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton left review comments

@joe-maley joe-maley joe-maley approved these changes

Assignees
No one assigned
Labels
internals refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stavrospapadopoulos @ihnorton @joe-maley