Split coordinates file into multiple files, one per dimension #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavrospapadopoulos
force-pushed
the
sp/split_coords_file
branch
10 times, most recently
from
263d1f7 to
48b6c5c
Compare
joe-maley
approved these changes
Dec 30, 2019
| @@ -216,6 +219,12 @@ class ArraySchema { | |||
| */ | |||
| Status has_attribute(const std::string& name, bool* has_attr) const; | |||
|
|
|||
| // Returns true if the input name is an attribute | |||
There was a problem hiding this comment.
Add a period at the end of this sentence so that it will be consistent with the other routine comments in this file. Same for line 225.
There was a problem hiding this comment.
Good catch, in fact the comment should have Doxygen format.
tiledb/sm/query/reader.cc
Outdated
| Status Reader::zip_coord_tiles( | ||
| const std::vector<ResultTile*>& tmp_result_tiles) const { | ||
| // Initialize zipped coordinate tiles | ||
| std::map<URI, std::vector<std::tuple<uint64_t, void*, uint64_t>>> all_regions; |
There was a problem hiding this comment.
this appears to be unused in this routine.
There was a problem hiding this comment.
Weird that the compiler did not catch it.
…ppropriate changes to Reader. Ensure backwards compatibility.
stavrospapadopoulos
force-pushed
the
sp/split_coords_file
branch
from
48b6c5c to
1065ac8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards addressing #93
__t1_t2_uuidto__t1_t2_uuid_<format_version>. That was necessary for backwards compatibility