-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set separate coordinate buffers to write queries #1458
Conversation
746ca67
to
b751407
Compare
b751407
to
01f29f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Serialization changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to worry about serialization compatibility with the REST server? For instance, if the REST server returns a query serialized with an older version, would we be able to properly deserialize it?
@@ -291,6 +296,18 @@ const Dimension* ArraySchema::dimension(unsigned int i) const { | |||
return domain_->dimension(i); | |||
} | |||
|
|||
const Dimension* ArraySchema::dimension(std::string name) const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const-ref name
std::vector<std::string> ret; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const size_t ret_size = attr_buffers_.size() + (coords_buffer_ ? 1 : coord_buffers_.size())
ret.reserve(ret_size)
The serialization format is buffer agnostic, previously we were using the list of attributes + |
@joe-maley the serialization format did not change in this PR. At a high level, the query serializes a set of named buffers. Supporting separate coordinate buffers really means allowing the named buffers to carry dimension names in addition to attributes and |
Thanks! Just checking. LGTM. |
53e5bef
to
9b0df7e
Compare
9b0df7e
to
010e14e
Compare
Towards addressing #93