Skip to content

Commit

Permalink
[NOT FOR MERGE] Bring object library generic_tile_io into conforman…
Browse files Browse the repository at this point in the history
…ce with standalone link policy

PR #4051 took object library `generic_tile_io` out of conformance with the policy that each OL should link standalone. This PR corrects this.

Note: In its present state this PR is not suitable for review or merge. It's branched from a branch that itself has not merged yet and needs to be rebased before review is feasible.
  • Loading branch information
eric-hughes-tiledb committed May 13, 2024
1 parent 002d84c commit a9ea361
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion tiledb/sm/array_schema/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,6 @@ conclude(object_library)
# the principle that object libraries must compile as standalone modules. As
# long as this directive is necessary to have to the compile test pass, we
# cannot consider `array_schema` as a properly-constructed object library.
target_link_libraries(compile_array_schema PRIVATE context_resources generic_tile_io)
target_link_libraries(compile_array_schema PRIVATE generic_tile_io)

add_test_subdirectory()
7 changes: 1 addition & 6 deletions tiledb/sm/tile/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,12 @@ commence(object_library generic_tile_io)
baseline
buffer
constants
context_resources
tiledb_crypto
filter_pipeline
tile
vfs
)
conclude(object_library)

# This is linked outside the object_library scope because ContextResources
# is recompiled as part of the capi_context_stub. Including context_resources
# here like this prevents many headaches revolving around duplicate symbols
# when linking executables.
target_link_libraries(compile_generic_tile_io PRIVATE context_resources)

add_test_subdirectory()

0 comments on commit a9ea361

Please sign in to comment.