-
Notifications
You must be signed in to change notification settings - Fork 185
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
TODO: Write a better commit message
- Loading branch information
Showing
57 changed files
with
5,945 additions
and
100 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
Chores Left | ||
=== | ||
|
||
* Testing | ||
* Throw error if enumeration has longer length than the integer width of the attribute | ||
* Require the attribute type to be integral when setting an enumeration | ||
* Don't allow signed integer values for attributes with enumeratiojns? Does R need this? | ||
* Require cell_val_num == 1 for attributes | ||
* Don't forget to test drop and then add attribute with enumeration. | ||
|
||
* Missing APIs | ||
* array schema evolution C API | ||
* QueryConditon C API | ||
|
||
* Miscellany | ||
* Add Enumeration::dump(FILE* out) | ||
* When serializing array schema, check that any enumerations set on attributes actually exist | ||
* Array::get_enumeration - might have to check all load schema versions? | ||
* Do loaded enumerations need serialized? | ||
* QueryAstNode rewrite_enumeration_condition - Need to adjust bit widths | ||
* Document enumeration format changes in the storage format docs | ||
|
||
* REST Serialization ToDOs | ||
* Enumerations initial implementation | ||
* Add ASTNode::use_enumeration to serialization code - If not, all remote queries are against enumeration values | ||
* Add attribute enumeration name | ||
|
||
* Use generate_uri instead of reimplementing the thinger if I did that | ||
|
||
* Coverage Reports | ||
* Add totals row to TOC | ||
* Do we generate files for headers with no executable lines? If not, track whcih ones are fake so that headers are green in the TOC when they only have non-executable changes | ||
* Add jump-to-first-uncovered link | ||
|
||
|
||
* Future TODO: | ||
* Update schema consolidation and vaccuming for enumerations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
--- | ||
title: Enumerations | ||
--- | ||
|
||
## Main Structure | ||
|
||
``` | ||
my_array # array folder | ||
| ... | ||
|_ schema # ArraySchema directory named `__schema` | ||
|_ enumerations # Enumeration directory named `__enumerations` | ||
| |_ enumeration # enumeration data with names `__t1_t2_uuid_v` | ||
Enumeration data is stored in a subdirectory of the [array schema][./array_schema.md] | ||
directory. Enumerations are stored using [Generic Tiles][./generic_tile.md]. | ||
Data stored in the generic tile follows the current format as of version 19. | ||
| **Field** | **Type** | **Description** | | ||
| :--- | :--- | :--- | | ||
| Version number | `uint32_t` | Format version number of the generic tile | | ||
| Datatype | `uint8_t` | The datatype of the enumeration values | | ||
| Cell Val Num | `uint32_t` | The cell val num of the enumeration values | | ||
| Ordered | `bool` | Whether the enumeration values should be considered ordered | | ||
| Data Size | `uint64_t` | The number of bytes used to store the values | | ||
| Data | `uint8_t` * Data Size | The data for the enumeration values | | ||
| Offsets Size | `uint64_t` | The number of bytes used to store offsets if cell_var_num is TILEDB_VAR_NUM | | ||
| Offsets | `uint8_t` * Offsets Size | The offsets data for the enumeration if cell_var_num is TILEDB_VAR_NUM | |
Oops, something went wrong.