Skip to content

Commit

Permalink
Channel operation needs virtual destructor.
Browse files Browse the repository at this point in the history
This came out of the maria DB nightlies returning the following error:
/usr/local/include/tiledb/channel_operation.h:71:3: error: 'tiledb::ChannelOperation' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]

The fix is trivial.

---
TYPE: NO_HISTORY
DESC: Channel operation needs virtual destructor.
  • Loading branch information
KiterLuc committed Oct 25, 2023
1 parent 83e6589 commit 033402c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tiledb/sm/cpp_api/channel_operation.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class ChannelOperation {
ChannelOperation& operator=(ChannelOperation&&) = default;

/** Destructor. */
~ChannelOperation() = default;
virtual ~ChannelOperation() = default;

/* ********************************* */
/* API */
Expand Down

0 comments on commit 033402c

Please sign in to comment.