Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to macos-13 runner image #783

Closed
wants to merge 2 commits into from

Conversation

jdblischak
Copy link
Collaborator

macos-12 runner image is deprecated

xref: actions/runner-images#10721, TileDB-Inc/TileDB#5350

@teo-tsirpanis
Copy link
Member

Apparently we use a too old Gradle version.

@jdblischak
Copy link
Collaborator Author

Rebased onto main to incorporate #786, which removed the spark jobs

@gspowley
Copy link
Member

gspowley commented Dec 4, 2024

It looks like javadoc "linting" is failing on macos. Is there a way to disable that?

@teo-tsirpanis
Copy link
Member

The error seems to be:

Execution failed for task ':sourceJar'.
> Entry io/tiledb/libvcfnative/VCFBedFile.java is a duplicate but no duplicate handling strategy has been set. Please refer to https://docs.gradle.org/8.10.2/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy for details.

@gspowley
Copy link
Member

gspowley commented Dec 5, 2024

Good point, when running locally on Linux I didn't get that error message.

This change allowed the build to complete on my local system.

diff --git a/apis/java/build.gradle b/apis/java/build.gradle
index 78c9fada..1a98c55b 100644
--- a/apis/java/build.gradle
+++ b/apis/java/build.gradle
@@ -213,6 +213,7 @@ task sourceJar(type: Jar) {
 task javadocJar(type: Jar, dependsOn: javadoc) {
     classifier "javadoc"
     from javadoc.destinationDir
+    duplicatesStrategy = DuplicatesStrategy.EXCLUDE
 }
 
 artifacts {

@jdblischak
Copy link
Collaborator Author

@teo-tsirpanis @gspowley thanks for the troubleshooting assistance!

@dudoslav opened a new PR #793 to combine everything, and the CI is green. Thanks Dušan!

@jdblischak jdblischak closed this Dec 5, 2024
@jdblischak jdblischak deleted the macos-13 branch December 5, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants