Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Python API for sample deletion #759

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

awenocur
Copy link
Contributor

@awenocur awenocur commented Aug 17, 2024

Add a Python API to delete samples.

@awenocur awenocur requested a review from gspowley August 17, 2024 05:41
@awenocur awenocur force-pushed the adamwenocur/sc-51448/delete-samples branch 3 times, most recently from 37beafa to cced55a Compare August 19, 2024 16:35
Copy link
Member

@gspowley gspowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One change requested and please add a description to the PR. Thanks!

libtiledbvcf/src/dataset/tiledbvcfdataset.cc Outdated Show resolved Hide resolved
@awenocur awenocur force-pushed the adamwenocur/sc-51448/delete-samples branch from cced55a to b4e49c8 Compare August 26, 2024 14:32
@gspowley gspowley merged commit b9fd438 into main Aug 28, 2024
13 checks passed
@gspowley gspowley deleted the adamwenocur/sc-51448/delete-samples branch August 28, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants