Hotfix: pin numpy < 2 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fun. The macos-11 jobs were immediately canceled due to a scheduled brownout.
Recall that we are stuck on macos-11 because of htslib: TileDB-VCF/.github/workflows/macos.yml Lines 21 to 23 in 7ff0bac |
|
I started a centralized nightly run using the branch adamwenocur/sc-49903/update (ie PR #732) (can't use my PR branch because it is on a fork) |
awenocur
approved these changes
Jun 24, 2024
This was referenced Jun 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the nightlies in this repo (#730) and my centralized nightlies (https://github.com/jdblischak/centralized-tiledb-nightlies/issues/12#issuecomment-2176240410) have been failing for a week due to the release of numpy 2. PRs #731 and #732 have the numpy<2 pin, but they are still undergoing review. To fix the nightly builds, I cherry-picked @awenocur's commit to pin numpy<2.