Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests to expect dense current domain #768

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

johnkerl
Copy link
Collaborator

@johnkerl johnkerl commented Oct 16, 2024

TileDB-Inc/centralized-tiledb-nightlies#24 (comment)

TileDB-Inc/TileDB#5303

Fixes #767

Current-domain support is now available for dense arrays in the upcoming core 2.27

@johnkerl johnkerl force-pushed the kerl/dense-current-domain branch from 0f0df6e to c9ad183 Compare October 16, 2024 14:51
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@@ -152,11 +152,3 @@ async function searchFuse(query, callback) {
});
});
})(window.jQuery || window.$)

document.addEventListener('keydown', function(event) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended to be removed or leftover local changes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just saw this post-merge

I ran devtools::document(); this was fully automated.

@johnkerl johnkerl merged commit 8e02c30 into main Oct 16, 2024
8 checks passed
@johnkerl johnkerl deleted the kerl/dense-current-domain branch October 16, 2024 15:06
johnkerl added a commit that referenced this pull request Oct 17, 2024
@johnkerl johnkerl mentioned this pull request Oct 17, 2024
johnkerl added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Nightly Dev Build job failed on Tuesday (2024-10-15)
2 participants