Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring of existing tests #698

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

eddelbuettel
Copy link
Contributor

The package had three smaller test files associated with existing test files. For schema evolution this was an added set of arrow tests which can be brought into the main file; for timetravel these were older simpler tests we had skipped at some points; and for tiledbarray these were some skipped tests. Merging two into the main files and removing the third tidies the test directory up a little and aligns the output more nice:

$ CI="true" Rscript -e 'tinytest::run_test_dir("inst/tinytest")'
test_aggregates.R.............   20 tests OK 1.0s
test_arrayschema.R............   30 tests OK 38ms
test_arrayschemaevolution.R...   64 tests OK 1.5s
test_arrowio.R................   39 tests OK 0.4s
test_attr.R...................   31 tests OK 0.3s
test_config.R.................   23 tests OK 17ms
test_ctx.R....................    8 tests OK 13ms
test_dataframe.R..............   58 tests OK 2.4s
test_datetime.R...............    5 tests OK 0.2s
test_dim.R....................  190 tests OK 2.1s
test_dimsubset.R..............   26 tests OK 7.8s
test_domain.R.................   13 tests OK 11ms
test_filestore.R..............   15 tests OK 0.3s
test_filter.R.................   56 tests OK 1.4s
test_filterlist.R.............    4 tests OK 5ms
test_fragmentinfo.R...........   25 tests OK 1.0s
test_group.R..................   71 tests OK 0.2s
test_libtiledb.R..............  179 tests OK 92ms
test_matrix.R.................    3 tests OK 0.3s
test_metadata.R...............   33 tests OK 0.3s
test_misc.R...................    2 tests OK 3ms
test_ordered.R................   16 tests OK 0.4s
test_query.R..................   49 tests OK 0.5s
test_querycondition.R.........  102 tests OK 2.1s
test_shmem.R..................    3 tests OK 0.2s
test_sparsematrix.R...........    8 tests OK 0.7s
test_tiledbarray.R............  244 tests OK 6.7s
test_timetravel.R.............   31 tests OK 2.7s
test_vfs.R....................   21 tests OK 0.2s
All ok, 1369 results (33.0s)
$ 

where in main branch we currently have

$ CI="true" Rscript -e 'tinytest::run_test_dir("inst/tinytest")'
test_aggregates.R.............   20 tests OK 1.0s
test_arrayschema.R............   30 tests OK 22ms
test_arrayschemaevolution_arrow.R    6 tests OK 0.3s
test_arrayschemaevolution.R...   58 tests OK 1.3s
test_arrowio.R................   39 tests OK 0.3s
test_attr.R...................   31 tests OK 0.3s
test_config.R.................   23 tests OK 13ms
test_ctx.R....................    8 tests OK 10ms
test_dataframe.R..............   58 tests OK 2.5s
test_datetime.R...............    5 tests OK 0.2s
test_dim.R....................  190 tests OK 2.3s
test_dimsubset.R..............   26 tests OK 8.7s
test_domain.R.................   13 tests OK 11ms
test_filestore.R..............   15 tests OK 0.2s
test_filter.R.................   56 tests OK 1.5s
test_filterlist.R.............    4 tests OK 5ms
test_fragmentinfo.R...........   25 tests OK 1.0s
test_group.R..................   71 tests OK 0.3s
test_libtiledb.R..............  179 tests OK 93ms
test_matrix.R.................    3 tests OK 0.3s
test_metadata.R...............   33 tests OK 0.3s
test_misc.R...................    2 tests OK 4ms
test_ordered.R................   16 tests OK 0.4s
test_query.R..................   49 tests OK 0.5s
test_querycondition.R.........  102 tests OK 2.0s
test_shmem.R..................    3 tests OK 0.2s
test_sparsematrix.R...........    8 tests OK 1.0s
test_tiledbarray_extra.R......    0 tests    2ms [Exited at #5: Skip for now]
test_tiledbarray.R............  235 tests OK 5.5s
test_timetravel_extra.R.......    4 tests OK 0.2s
test_timetravel.R.............   27 tests OK 2.6s
test_vfs.R....................   21 tests OK 0.3s
All ok, 1360 results (33.4s)
$ 

so the same 1360 tests run but the display is now a littler as shown above/

@eddelbuettel
Copy link
Contributor Author

Thanks @awenocur !

@eddelbuettel eddelbuettel merged commit 748704b into master Apr 17, 2024
1 check passed
@eddelbuettel eddelbuettel deleted the de/sc-45344/refactor_some_tests branch May 3, 2024 03:13
@eddelbuettel eddelbuettel mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants