Add tiledb_vfs_ls_recursive() #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
Shelnutt2,
ihnorton,
awenocur and
mojaveazure
awenocur
approved these changes
Apr 11, 2024
|
Thank you @awenocur ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward export of the functionality provided in the vfs_experimental header.
Currently no unit test as we don't generally hit S3 from CI but may add a simple one conditional on having one of the AWS_* environment variables set so that it would run regularly in (local) dev. I presume we have a better pattern somewhere? Is there a something I should add as a secret to the GHA setup?
[ Edit: I added one, hitting "s3://tiledb-test-arrays/1.4/customer" if AWS_ACCESS_KEY_ID is non-zero. ]