Refactor one function to quieten compiler warning #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a little usage example to one help page and adds a small improvement to a recent change
|
This pull request has been linked to Shortcut Story #38600: Refactor one function call to avoid compiler warning. |
awenocur
approved these changes
Dec 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the dispatching into
tiledb::ObjectIter. When trying to build under the thread sanitizer (which ultimately did not work) the function tickled a warning aboutwalk_orderpossibly unintialized which is correct as the existing code was co-dependent on recursive mode being set. This has been improved.The PR also adds a little usage example to the help page for
built_asdumper, the code is not exposed as we cannot assume to have a JSON parser loaded, and adds a small improvement to a recent change in enumeration / factor handling in writes.