Allow using list of coordinates for writes/reads #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, but the default should be to not materialize a dataframe by default IMO (at least for dense). |
jakebolewski
approved these changes
Jan 30, 2019
Shelnutt2
force-pushed
the
ss/allow-using-lists-coords-for-access
branch
from
5241a9b to
4b0e30d
Compare
Dense arrays do not currently support sparse writes. When they do this will just work
Shelnutt2
force-pushed
the
ss/allow-using-lists-coords-for-access
branch
from
4b0e30d to
ca6ad9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using list of coordinates for writes/reads. Dense currently does not support sparse writes, but the foundation was laid for support.