Fix a few typos and links in the vignette #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,15 +30,14 @@ vignette discusses similar examples. | |||
| In the following examples, the URIs describing arrays point to local file system object. When TileDB | |||
| has been built with S3 support, and with proper AWS credentials in the usual environment variables, | |||
| URIs such as `s3://some/data/bucket` can be used where a local file would be used. See the script | |||
| [examples/ex_S3.R](https://github.com/TileDB-Inc/TileDB-R/blob/master/inst/examples/ex_S3.R) for an | |||
| example. | |||
| [examples/ex_S3.R][ex_s3] for an example. | |||
There was a problem hiding this comment.
I actually put that in as absolute URL for a reason ... so that it would resolve to the file nomatter how the vignette is viewed.
What we have now seems incorrect in the sense that Never mind. Reading to the end helps. Not my preferred style to split'em but whatever works.[...][...] (i.e. two sets of square brackets) is not valid markdown AFAIK.
There was a problem hiding this comment.
Those are reference links: https://spec.commonmark.org/0.29/#link-reference-definition.
There was a problem hiding this comment.
Since they're referenced multiple times in the text I thought it was beneficial to have all the URLs in once place.
There was a problem hiding this comment.
That is a valid argument.
eddelbuettel
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.