Add support for heterogeneous and string dimensions #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the read, write, and indexing paths to support heterogeneous and string dimensions, and adds or updates associated tests. --- Add ArraySchema.has_attr wrapping tiledb_array_schema_has_attribute Add wrapping for tiledb_dim...get_cell_val_num and _has_dimension Add basic Dim support (and test) for creating string dimensions checkpoint checkpoint checkpoint checkpoint checkpoint rename to core.cc py2 syntax remove tmp convert stuff checkpoint checkpoint checkpoint Format fix checkpoint Support split coordinates checkpoint: multi_index tests checkpoint: ncell_int test need to use uint8 rather than typed elem, because can't resize for var-length add pycall debugging helper checkpoint: 1 DenseArrayTest failure (Re-fix resizing codepath to set type correctly) checkpoint: passing all DenseArrayTest checkpoint: passing all sparse tests except the warning datetime dtype support checkpoint: fix uninit memory more test updates for split coords checkpoint: fix buffer size bug, all tests passing clean up imports etc move debug helpers to separate file nfc add include dirs for core ext fix mixed dim (uint64 + double) test remove use of deprecated+unused max_buffer definitions remove dead indexing code support mixed-dim writes fully separate and fix ranges for mixed-dim range writes missing import checkpoint: passing (add tests for multi_index var-length queries) checkpoint: working string reads and writes add nonempty domain support for string domains fix nonempty_domain str allocation
ihnorton
force-pushed
the
ihn/upd_heter_dim2
branch
3 times, most recently
from
a8eb45a to
eef5f01
Compare
ihnorton
force-pushed
the
ihn/upd_heter_dim2
branch
from
eef5f01 to
65fa530
Compare
- Add tests for string dimension domain - Fix full-range ':' indexing for string dimensions - Fix warnings/deprecations/unused - Fixes for python2
ihnorton
force-pushed
the
ihn/upd_heter_dim2
branch
from
65fa530 to
2d21a08
Compare
Shelnutt2
approved these changes
May 4, 2020
|
Great work! The pybind11 is quite nice 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the read, write, and indexing paths
to support heterogeneous and string dimensions, and adds or updates
associated tests.
fixes #177
fixes [ch1827]