Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the logic of daily tests to ensure both variations of numpy are run #2136

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

kounelisagis
Copy link
Member

Daily tests, and specifically daily-test-build-numpy.yml, are a way to test TileDB-Py against different versions of numpy. Historically, the workflow checks TileDB-Py with the oldest and newest supported numpy versions.

It turns out that the logic is not working as intended. As shown in the latest scheduled workflow, it appears that ci3, which uses daily-test-build-numpy.yml, only runs once for each Python version and operating system combination. There is no numpy dimension. This was discovered after #2127, which could have been prevented.

It seems we have used the configuration expansion described here: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-expanding-configurations. In practice, this adds an additional variable named numpy-version with just one of the specified values, but not all of them. I guess the selected one depends on the order of presence in the yaml file.

This PR resolves the issue and includes all the variations we want to check in the strategy matrix making use of the exclude syntax, the only way I can think of without having to explicitly set every combination.

I know that the combinations are a lot and I'm, of course, open to reduce them, even if this workflow runs once per day.

Latest scheduled workflow: https://github.com/TileDB-Inc/TileDB-Py/actions/runs/12645542541
Workflow of this branch: https://github.com/TileDB-Inc/TileDB-Py/actions/runs/12657985171


[sc-61402]

@kounelisagis kounelisagis requested a review from ihnorton January 7, 2025 19:35
@ihnorton ihnorton requested a review from dudoslav January 7, 2025 20:19
@kounelisagis kounelisagis merged commit 3c9d11c into main Jan 9, 2025
117 checks passed
@kounelisagis kounelisagis deleted the agis/fix-logic-daily-tests branch January 9, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants