[Merge 2.11] Addition of test_from_numpy_empty_str
#1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #17710: Cannot write array of all empty strings with from_numpy. |
nguyenv
force-pushed
the
viviannguyen/sc-17710/cannot-write-array-of-all-empty-strings-with
branch
from
dfdac03 to
58d42a0
Compare
ihnorton
reviewed
May 12, 2022
61 tasks
nguyenv
force-pushed
the
viviannguyen/sc-17710/cannot-write-array-of-all-empty-strings-with
branch
from
74a3c64 to
3f1b5f8
Compare
nguyenv
changed the title
npbuffer.cc::convert_object Fix: Empty String Needs sz=1test_from_numpy_empty_str
|
This bug has been fixed in core, so a fix in TileDB-Py is no longer needed. This PR now just contains modified and additional unit tests for empty strings. |
nguyenv
force-pushed
the
viviannguyen/sc-17710/cannot-write-array-of-all-empty-strings-with
branch
from
3f1b5f8 to
210ace6
Compare
nguyenv
changed the title
test_from_numpy_empty_strtest_from_numpy_empty_str
nguyenv
changed the title
test_from_numpy_empty_strtest_from_numpy_empty_str
nguyenv
force-pushed
the
viviannguyen/sc-17710/cannot-write-array-of-all-empty-strings-with
branch
from
9fa8137 to
4661ae0
Compare
nguyenv
force-pushed
the
viviannguyen/sc-17710/cannot-write-array-of-all-empty-strings-with
branch
from
4661ae0 to
fcab931
Compare
nguyenv
deleted the
viviannguyen/sc-17710/cannot-write-array-of-all-empty-strings-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\x00fortest_varlen_sparse_all_empty_strings