-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torch>=2.0 Unittest support #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are touching this file, should update the action versions as they are generating warnings.
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
The latest are:
- actions/checkout@v4
- actions/setup-python@v5
- actions/cache@v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add a version that runs on a more modern Python and PyTorch?
Suggest Python 3.12, Torch ~2.4 and torchdata 0.8 (latest)
Digging through the logs for the 2.0 run there are a error messages, but I'm not sure any of them matter.
|
For the pytorch implementation doesn't matter but I guess since we fully install the tiledb-ml package inside the UDF images this will create some issues with the |
If you use one release back, I think it works:
This gets me numpy 1.26.4 without complaint |
436c669
to
7354415
Compare
7354415
to
fba936c
Compare
Looking at the latest fail, the tensorflow-cpu pin is too low. In my succesfull install, I believe I used an unpinned |
This PR:
torch>=2.0
for all python versions.This can unblock any pending work that requires the aforementioned dependency.