Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug 8138: cache-control #8141

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Fix bug 8138: cache-control #8141

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38f1275
cache-control no-store by default
joshuafontany Apr 10, 2024
1ae9a71
clarify comment spec reference
joshuafontany Apr 10, 2024
00bb39e
comment typo
joshuafontany Apr 10, 2024
c7ca6c7
fix else formatting
joshuafontany Apr 11, 2024
c5ced20
Update server.js
joshuafontany Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/modules/server/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ function sendResponse(request,response,statusCode,headers,data,encoding) {
return;
}
}
} else {
// RFC 7231, 6.1. Overview of Status Codes:
// Browser clients may cache 200, 203, 204, 206, 300, 301,
// 404, 405, 410, 414, and 501 unless given explicit cache controls
headers["Cache-Control"] = headers["Cache-Control"] || "no-store";
}
/*
If the gzip=yes is set, check if the user agent permits compression. If so,
Expand Down
Loading