-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add archive HTML wikis, add index.html + css #7776
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @pmario we use the |
As far as I can see, there are no parameters. There are only environment variables. IMO the important one to store the built content is So how do you change that when your create a release or prerelease |
Apologies, we do indeed pass parameters via environment variables. The The script could check the value of |
@Jermolene ... This is ready for review and testing, since you do plan a new major version. It works locally on my ubuntu 22.04 system. But I cannot test the CI version |
@Jermolene -- This is ready for review again. If TW_BUILD_ARCHIVE is set to Since |
Hi @pmario that seems a little confusing to have to keep the two parameters in sync like that. I was expecting TW_BUILD_ARCHIVE would just be a flag telling the script whether or not to build the archive. |
@Jermolene -- ready for testing again. As you know, I cannot test the CI function. If you push the next update the prerelease should not create an archive version. |
Thank you @pmario and apologies for the delay. |
* add archive HTML wikis, add index.html + css * only build archive for release version * tested and add more docs * fix indent * fix spacing * add $TW5_BUILD_OUTPUT_ARCHIVE env variable for testing * use $TW5_BUILD_OUTPUT_ARCHIVE to check if archive should be built * use TW5_BUILD_ARCHIVE as requested
@pmario is this meant to be run via CI and to automatically update the archive? I do not see that an entry has been created for v5.3.2 |
@saqimtiaz Yes, It should create the archive automatically. -- But as I wrote in the OP I cannot test it, since the build process does not run with my repo. IMO it can only be tested, if @Jermolene creates a new version, since the prerelease should not create an archive version |
Hi @pmario we've had two releases of new versions of TiddlyWiki since this PR was merged; wouldn't that have been enough to trigger your script? |
I do not have a GitHub CI bot. My setup and directory structure is completely different to yours. I have no idea, how to test the configuration with your settings. |
Hi @pmario as I understand it, this PR contains an update to our CI script to make it save the archive version. You weren't able to test it for reasons that I understand, but what I don't understand is that we've now got to the point where the script has been run many times, including two releases. That makes me think that we should now be in a position to (a) determine whether the modifications in this PR worked and (b) to fix them if not. |
I found them: https://github.com/Jermolene/jermolene.github.io/tree/master/archive The output path was wrong. I'll create a new PR soon. The index.html works and should be updated once we update the TiddlyWiki Archive tiddler as a "docs only" update |
index.html and static.css need to stay in the archive directory as an index file. |
archive
directoryindex.html
+static.css
file in the archive dir@Jermolene ... I do not know it works with your workflow of creating a new major release, because I do not know how you activate it. Please test if the files are created in the right directories.