Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search and tag support for the wikilist #262

Merged

Conversation

Telumire
Copy link
Contributor

@Telumire Telumire commented Dec 6, 2022

This PR add several changes:

  • plugins/tiddlydesktop/WikiList Edit Tags Template.tid : an updated and improved version of $:/core/ui/EditTemplate/tags that allow to add tags to the wiki listed, while restricting the tags in the autocompletion dropdown to only the tags added to other wikis.
  • plugins/tiddlydesktop/WikiList SearchList Style.tid : stylesheet for the search field and the tags right bellow the search field
  • plugins/tiddlydesktop/WikiList ui Buttons DeleteUnusedTags.tid : button to delete unused tags. Since the wikilist tiddlers reset themself when they are open, the tags are saved on an intermediate tiddlers. If the wiki file is moved, it will be removed from the list but the tags will remain, this button allow to easily clean these tags. It has the tag $:/tags/StartupAction to automate the process on restart.
  • plugins/tiddlydesktop/WikiList.tid : added a field to search the list, tagpills to filter the list, the button to clean the remaining tags if needed, and modified the list-tagged-draggable macro to be filter-able.
  • plugins/tiddlydesktop/WikiListRow.tid : added the tag picker ui

@Jermolene
Copy link
Member

Thanks @Telumire I'm trying it out now, looks great and mostly working as expected.

I have three wikis in my file list window. I'm finding that some searches cause two of the wikis to be returned twice, showing a total of five wikis. It's hard to see the pattern. For example, all my wikis have "jer" in the title and the pathname. Searching for "je" returns three wikis, but adding an "r" to search for "jer" returns five wikis.

Aesthetically, I think it might look better to lose the border around the tag box but I do see that that might cause the tag pills to be confused for the command pills. Perhaps any further visual improvements should be a subsequent PR – I'd like to consider alternatives for the command buttons; they take up a lot of space and are distracting. Perhaps a popup menu would be better instead.

@Telumire
Copy link
Contributor Author

Telumire commented Dec 6, 2022

I have three wikis in my file list window. I'm finding that some searches cause two of the wikis to be returned twice, showing a total of five wikis. It's hard to see the pattern. For example, all my wikis have "jer" in the title and the pathname. Searching for "je" returns three wikis, but adding an "r" to search for "jer" returns five wikis.

😬I only tried with two, I will search for a fix !

Aesthetically, I think it might look better to lose the border around the tag box but I do see that that might cause the tag pills to be confused for the command pills. Perhaps any further visual improvements should be a subsequent PR – I'd like to consider alternatives for the command buttons; they take up a lot of space and are distracting. Perhaps a popup menu would be better instead.

I'm going to correct the issues you mentioned, then if I have suggestions to improve the design I'll make a new PR :) I agree that the UI could be improved.

@Telumire
Copy link
Contributor Author

Telumire commented Dec 6, 2022

@Jermolene I was unable to replicate the issue but I added a unique[] filter operator that should take care of duplicates in the list of results.

@Jermolene
Copy link
Member

Thanks for your patience @Telumire. It looks good now – I was experiencing some bugs that turned out to be due to the corrupt configuration tiddlers. I'll merge now, and release v0.0.15

@Jermolene Jermolene merged commit d3b4b8f into TiddlyWiki:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants