-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enforce required arguments, fixes #72 #81
Conversation
@ethe Can you have a look? It doesn't validate argument type though. |
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 80.57% 80.61% +0.04%
==========================================
Files 35 35
Lines 3480 3493 +13
==========================================
+ Hits 2804 2816 +12
- Misses 676 677 +1
Continue to review full report at Codecov.
|
Thank you! BTW, could you mind to add some test cases to ensure the behavior of your enhancement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! BTW, could you mind to add some test cases to ensure the behavior of your enhancement?
Added test cases.
I think it is fine, merged it. The client does not check the type of arguments, it is by design. |
No description provided.