Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce required arguments, fixes #72 #81

Merged
merged 3 commits into from
Sep 1, 2019
Merged

enforce required arguments, fixes #72 #81

merged 3 commits into from
Sep 1, 2019

Conversation

iamsudip
Copy link
Contributor

No description provided.

@iamsudip
Copy link
Contributor Author

@ethe Can you have a look? It doesn't validate argument type though.

@codecov
Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #81 into master will increase coverage by 0.04%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   80.57%   80.61%   +0.04%     
==========================================
  Files          35       35              
  Lines        3480     3493      +13     
==========================================
+ Hits         2804     2816      +12     
- Misses        676      677       +1
Impacted Files Coverage Δ
thriftpy2/contrib/aio/client.py 82.45% <100%> (+0.63%) ⬆️
thriftpy2/thrift.py 76.34% <94.11%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4aa812...74b93d0. Read the comment docs.

@ethe
Copy link
Member

ethe commented Sep 1, 2019

Thank you! BTW, could you mind to add some test cases to ensure the behavior of your enhancement?

Copy link
Member

@ethe ethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way,

thriftpy2/thrift.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@iamsudip iamsudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! BTW, could you mind to add some test cases to ensure the behavior of your enhancement?

Added test cases.

thriftpy2/thrift.py Outdated Show resolved Hide resolved
@ethe
Copy link
Member

ethe commented Sep 1, 2019

I think it is fine, merged it. The client does not check the type of arguments, it is by design.

@ethe ethe merged commit 90cbc37 into Thriftpy:master Sep 1, 2019
@iamsudip iamsudip deleted the enforce_req_args branch September 1, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants