Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo word #123

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Fix typo word #123

merged 5 commits into from
Sep 27, 2023

Conversation

truebit
Copy link
Contributor

@truebit truebit commented Mar 3, 2020

fix issue #122

@aisk
Copy link
Member

aisk commented Mar 3, 2020

I think we should have an alias for ThriftGrammerError for don't break unit test and users' codes.

And maybe we can declare a module level __getattr__ which descibed in PEP 562, for users who are using Python3.7 or latter versions can got a deprecated warning.

@truebit
Copy link
Contributor Author

truebit commented Apr 23, 2020

IMHO, this change do not need to consider backward compatibility due to the ROI of this change. Anyone used old ThriftGrammerError would be easy to find out the changed class name.

@ethe
Copy link
Member

ethe commented Apr 23, 2020

I think it would be better to keep backward compatibility, I have to release a minor version after this pull request be merged, it is not necessary

@aisk aisk force-pushed the master branch 2 times, most recently from 70cb987 to 94dff34 Compare September 15, 2023 11:54
@aisk
Copy link
Member

aisk commented Sep 15, 2023

The only cocern is the error message is changed, but I think this will only affect thriftpy2's test.

@aisk aisk requested a review from ethe September 15, 2023 12:08
@ethe ethe merged commit 2a6f591 into Thriftpy:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants