Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 properties to OcelotPipelineConfiguration class for more flexibility in pipeline #1497

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ArsalanMoniee
Copy link

@ArsalanMoniee ArsalanMoniee commented Jul 26, 2021

Fixes / New Feature

In a recent project, I needed to use existing and custom Authorization side by side. In the current situation, using custom Authorization before the original Authorization would reduce performance. Because in my custom Authorization service, it was necessary to call a specific web API.
Calling that web API before authentication would create a load for routes which were not existed in upstream. (ocelot json)
as well as the web API only call for valid request!

Proposed Changes

  • Added 2 properties to OcelotPipelineConfiguration class for more flexibility in Ocelot's pipeline

stefancruz added a commit to stefancruz/Ocelot that referenced this pull request Dec 22, 2022
@raman-m raman-m self-requested a review June 30, 2023 18:55
@raman-m raman-m force-pushed the feature/add-feature-for-ocelot-pipeline-configuration branch from 5effa06 to 3560bb9 Compare August 25, 2023 14:00
@raman-m raman-m changed the title add 2 property to PipelineConfiguration claas for more flexibility in pipieline Add 2 properties to 'OcelotPipelineConfiguration' claas for more flexibility in pipieline Aug 25, 2023
@raman-m
Copy link
Member

raman-m commented Aug 25, 2023

The feature branch has been rebased onto ThreeMammals:develop!
Welcome to code review!


@ArsalanMoniee
I see that develop branch in your fork has been updated, but is not identical to the head one: the repo has some diff because of merge commits. Could we fix that plz?
Could you add me as collaborator to your forked repo please? I will try to remove this diff in develop branch.

@raman-m raman-m added feature A new feature needs feedback Issue is waiting on feedback before acceptance labels Aug 25, 2023
RaynaldM
RaynaldM previously approved these changes Aug 28, 2023
Copy link
Collaborator

@RaynaldM RaynaldM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you correct you PR title :
claas => class
pipieeline => pipeline

@raman-m raman-m changed the title Add 2 properties to 'OcelotPipelineConfiguration' claas for more flexibility in pipieline Add 2 properties to 'OcelotPipelineConfiguration' class for more flexibility in pipeline Aug 28, 2023
@raman-m
Copy link
Member

raman-m commented Aug 28, 2023

@RaynaldM left a comment on on Aug 28

Done!

@raman-m raman-m changed the title Add 2 properties to 'OcelotPipelineConfiguration' class for more flexibility in pipeline Add 2 properties to OcelotPipelineConfiguration class for more flexibility in pipeline Feb 18, 2024
@raman-m raman-m added the 2023 Annual 2023 release label Mar 5, 2024
@raman-m raman-m added this to the Annual 2023 milestone Mar 5, 2024
@raman-m raman-m changed the base branch from develop to release/24.0 March 5, 2024 10:02
@raman-m raman-m force-pushed the feature/add-feature-for-ocelot-pipeline-configuration branch from 2a8f3dc to 2c7ded4 Compare April 7, 2024 13:03
@raman-m raman-m force-pushed the feature/add-feature-for-ocelot-pipeline-configuration branch from 2c7ded4 to 4873224 Compare April 16, 2024 17:43
@raman-m
Copy link
Member

raman-m commented Apr 16, 2024

The branch has been rebased onto release/24.0 with top commit 59b63ea !

@raman-m raman-m force-pushed the feature/add-feature-for-ocelot-pipeline-configuration branch from 4873224 to 9bee3af Compare April 19, 2024 17:18
@raman-m raman-m changed the base branch from release/24.0 to develop June 13, 2024 10:14
@raman-m raman-m force-pushed the feature/add-feature-for-ocelot-pipeline-configuration branch from 9bee3af to 0b704a9 Compare June 14, 2024 16:21
@raman-m raman-m added Oct'24 October 2024 release and removed 2023 Annual 2023 release labels Oct 9, 2024
@raman-m raman-m modified the milestones: Annual 2023, October'24 Oct 9, 2024
@raman-m raman-m added proposal Proposal for a new functionality in Ocelot Autumn'24 Autumn 2024 release Middlewares Ocelot feature: Middleware Injection and removed needs feedback Issue is waiting on feedback before acceptance Oct'24 October 2024 release labels Oct 26, 2024
@raman-m raman-m modified the milestones: October'24, Autumn'24 Oct 26, 2024
ArsalanMoniee and others added 6 commits November 4, 2024 20:09
…operty to OcelotPipelineConfiguration claas for more flexibility in pipieline
…l prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.
@raman-m raman-m force-pushed the feature/add-feature-for-ocelot-pipeline-configuration branch from 0b704a9 to f8662f4 Compare November 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Autumn'24 Autumn 2024 release feature A new feature Middlewares Ocelot feature: Middleware Injection proposal Proposal for a new functionality in Ocelot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants