Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1739 #2177 OpenIddict authentication: role section, override scope and role key #1431

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Eits-Ian
Copy link

@Eits-Ian Eits-Ian commented Feb 7, 2021

Fixes #2177

Proposed Changes

  • Added role section
  • Variable to define an override for the scope or role descriptor

"ScopeKey": "oi_scp" to enable OpenIddict

"RequiredRole": [ "User" ]

Successor

Closes #1739

@raman-m
Copy link
Member

raman-m commented Jul 11, 2023

Hi @Eits-Ian !
Thanks for your interest in Ocelot gateway!

Please do the following:

  • Merge PR 1
  • Rebase feature branch onto develop
  • Resolve all merge conflicts

@raman-m raman-m added the conflicts Feature branch has merge conflicts label Jul 11, 2023
@raman-m raman-m added feature A new feature proposal Proposal for a new functionality in Ocelot needs feedback Issue is waiting on feedback before acceptance and removed conflicts Feature branch has merge conflicts labels Aug 23, 2023
@raman-m
Copy link
Member

raman-m commented Aug 23, 2023

@Eits-Ian
I thought you needed a help to resolve the conflicts.
The feature branch has been rebased onto ThreeMammals:develop successfully!
Now we have 4 failed tests!
We cannot start code review till all tests have passed...


I see that develop branch in your fork is old.
Could you Sync fork please? So, the develop branch will be updated with all top commits!
Could you add me as collaborator to your forked repo please? I will update develop branch.

Copy link
Member

@raman-m raman-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 failed tests!
Could you review & fix them please?

@Eits-Ian
Copy link
Author

Sorry I did not get a chance to look at this till today, should be fixed, have added you as a collaborator, I hadn't looked at this for a couple of years. Need to add process policies, I am really busy at the moment so will not be able to get to this for a while.

@Eits-Ian
Copy link
Author

The error is at ClaimsToDownstreamPathTests it is not authenticating, I need to take a look at what is happening but it will need to be later

@raman-m
Copy link
Member

raman-m commented Aug 28, 2023

@Eits-Ian commented on Aug 24

Thanks for caring!
I am planning to help you in September by having of some pair programming...
Sorry, now I have a lot of things to do with this project...

@raman-m raman-m added the 2023 Annual 2023 release label Mar 5, 2024
@raman-m raman-m added this to the Annual 2023 milestone Mar 5, 2024
@raman-m raman-m changed the base branch from develop to release/24.0 March 5, 2024 10:04
@raman-m
Copy link
Member

raman-m commented Apr 16, 2024

The branch has been rebased onto release/24.0 which has top commit 59b63ea !

  • Further development is required❕
  • Fixing failed tests is required❗

@raman-m
Copy link
Member

raman-m commented Apr 16, 2024

@Eits-Ian Dear author,
Are you still with Ocelot?
And, what's your name? 😉

Will this PR close, is PR related to the following issues?

Please answer ASAP❗

P.S.

OpenIddict implementation, role section, override scope and role key

What is OpenIddict? It should likely not be part of the PR title; instead, the title should include Ocelot's artifact name or, if necessary, the ASP.NET one.

@raman-m raman-m added waiting Waiting for answer to question or feedback from issue raiser and removed needs feedback Issue is waiting on feedback before acceptance labels Apr 16, 2024
@Eits-Ian
Copy link
Author

Eits-Ian commented Apr 18, 2024 via email

@raman-m
Copy link
Member

raman-m commented Apr 19, 2024

I haven't got much time to do much with this at the moment, I will need to get back into it as I must update the api, that use this, but that will not be for a few months

It should be a matter of weeks, not months!

@Eits-Ian
Copy link
Author

Eits-Ian commented Apr 19, 2024 via email

@raman-m
Copy link
Member

raman-m commented Apr 19, 2024

@Eits-Ian
I don't understand you!
Should we close the PR or will you develop it in coming future?

@Eits-Ian
Copy link
Author

Eits-Ian commented Apr 19, 2024 via email

@raman-m
Copy link
Member

raman-m commented Apr 19, 2024

🆗 Got it! You are super busy… In this case, let me decide what to do with this PR…

@raman-m raman-m added Oct'24 October 2024 release and removed 2023 Annual 2023 release labels Oct 9, 2024
@raman-m raman-m modified the milestones: Annual 2023, October'24 Oct 9, 2024
@raman-m raman-m added high High priority Authentication Ocelot feature: Authentication and removed low Low priority labels Oct 19, 2024
@raman-m
Copy link
Member

raman-m commented Oct 19, 2024

Successor

This dependency can be addressed by giving high priority to merging this PR first, followed by PR #1478.

@raman-m raman-m changed the title OpenIddict implementation, role section, override scope and role key #2177 OpenIddict implementation: role section, override scope and role key Oct 19, 2024
@raman-m raman-m self-assigned this Oct 19, 2024
@raman-m
Copy link
Member

raman-m commented Oct 19, 2024

We should introduce a new "scopes matching strategy" feature directly in this PR due to the previously discussed issues in:

@raman-m raman-m changed the title #2177 OpenIddict implementation: role section, override scope and role key #1739 #2177 OpenIddict authentication: role section, override scope and role key Oct 19, 2024
@raman-m raman-m added Dec'24 December 2024 release and removed Oct'24 October 2024 release labels Oct 26, 2024
@raman-m raman-m modified the milestones: October'24, Autumn'24 Oct 26, 2024
Eits-Ian and others added 10 commits November 5, 2024 13:22
"ScopeKey": "oi_scp" to enable OpenIddict
"RequiredRole": [ "User" ]
Registered IRolesAuthorizer
Fixed Test should_not_be_valid_if_specified_authentication_provider_isnt_registered()
Fixed test configuration_is_invalid_with_invalid_authentication_provider()
@raman-m
Copy link
Member

raman-m commented Nov 5, 2024

Further Development Required❗

The 5 failed acceptance tests need to be addressed!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Authentication Ocelot feature: Authentication Dec'24 December 2024 release feature A new feature high High priority proposal Proposal for a new functionality in Ocelot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AllowedScopes feature is not functioning as anticipated during authentication with the OpenIddict server
2 participants