Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long duration of CircleCI builds #2034

Closed
raman-m opened this issue Apr 8, 2024 · 1 comment · Fixed by #2045
Closed

Long duration of CircleCI builds #2034

raman-m opened this issue Apr 8, 2024 · 1 comment · Fixed by #2045
Assignees
@raman-m
Labels
bug Identified as a potential bug CircleCI CI-CD subsystem merged Issue has been merged to dev and is waiting for the next release proposal Proposal for a new functionality in Ocelot Spring'24 Spring 2024 release
Milestone
Spring'24

Comments

@raman-m
Copy link
Member

raman-m commented Apr 8, 2024 •
edited
Loading

Expected Behavior

It would be good if build will take no more than 5-6 minutes, less is better.

Actual Behavior

Success CircleCI build takes around 12-13 minutes.

The old duration in 2023 for 19.x releases was around 2 minutes only!!! After migration to .NET 8 the duration had increased to ~6 minutes because of 3 SDKs builds. We need to decrease build time down to 6 minutes, but it is better to parallelize the build and decrease overall build time down to 2-3 minutes.

Long lasting Unit tests, >10 sec

Long lasting Integration tests, >10 sec

Long lasting Acceptance tests, >10 sec

Specifications

  • Version: 23.2.2
  • Subsystem: CircleCI
@raman-m raman-m self-assigned this Apr 8, 2024
@raman-m raman-m added bug Identified as a potential bug proposal Proposal for a new functionality in Ocelot Spring'24 Spring 2024 release CircleCI CI-CD subsystem labels Apr 8, 2024
@raman-m raman-m added this to the March-April'24 milestone Apr 8, 2024
@raman-m raman-m added highest Highest priority accepted Bug or feature would be accepted as a PR or is being worked on in progress Someone is working on the issue. Could be someone on the team or off. labels Apr 8, 2024
@raman-m raman-m mentioned this issue Apr 12, 2024
Merged
raman-m added a commit that referenced this issue Apr 12, 2024
@raman-m
#2034 More rapid CircleCI builds (Part 1) (#2045)
59b63ea 
* Override `DefaultRequestTimeoutSeconds` by new property

* Build using .NET 8 SDK only

* Build all 3 SDKs if target is Release

* Run "dotnet tool restore" to make the "dotnet-cake" command available

* Update GitVersion.Tool package

* GitVersion.Tool 5.12.0

* Newtonsoft.Json

* Review packages

* Prepare folder structure for samples

* samples Administration

* Move Docker files

* samples solution folder

* Move ServiceFabric folders

* Rename ServiceFabric folders

* Re-add OcelotApplication of ServiceFabric sample

* New Samples view in Visual Studio

* Add Ocelot.Samples.sln

* Add Ocelot.Release.sln

* Remove Samples projects from main solution

* log settings of Compile task

* Remove legacy build settings file

* queue/block_workflow

* resource_class

* Update .editorconfig

* CS8936: Feature 'primary constructors' is not available in C# 10, 11.
Feature 'primary constructors' is available in C# 12.0 or greater. But we use `net6.0` and `net7.0`

* CS8936 Feature 'collection expressions' is not available in C# 10, 11.
CS8936: Feature 'primary constructors' is not available in C# 10, 11.

* CS0618: 'member' is obsolete: 'text'.
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0618
Switch off the warning CS0618 for testing projects.

* Fix warnings.

xUnit1013 Public method 'GivenThereIsAnIdentityServerOn' on test class 'AuthenticationTests' should be marked as a Theory. Reduce the visibility of the method, or add a Theory attribute to the method.

CS0618 'FileAuthenticationOptions.AuthenticationProviderKey' is obsolete: 'Use the AuthenticationProviderKeys property!'.

* Don't restore and don't build in RunUnitTests target

* --verbosity:detailed

* Disable BDDfy console report

* enable

* Inherit from `UnitTest`
@raman-m raman-m added merged Issue has been merged to dev and is waiting for the next release and removed accepted Bug or feature would be accepted as a PR or is being worked on in progress Someone is working on the issue. Could be someone on the team or off. highest Highest priority labels Apr 12, 2024
@raman-m
Copy link
Member Author

raman-m commented Apr 12, 2024

TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raman-m raman-m

Labels
bug Identified as a potential bug CircleCI CI-CD subsystem merged Issue has been merged to dev and is waiting for the next release proposal Proposal for a new functionality in Ocelot Spring'24 Spring 2024 release
Projects
None yet
Milestone
Spring'24
Development

Successfully merging a pull request may close this issue.

#2034 More rapid CircleCI builds (Part 1) ThreeMammals/Ocelot
1 participant
@raman-m