Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to allow ignoring command reply publishing errors #441

Merged

Conversation

balenio
Copy link
Contributor

@balenio balenio commented May 23, 2024

Command reply topics can be ephemeral (e.g. tied to the lifetime of the service instance that published the command). In those cases an error publishing to the reply topic can be final, i.e. not recoverable by NACKing and retrying and would cause the reply message to spin needlessly. This change adds a configuration option in the form of a function callback that allows to inspect the error and optionally ignore it, while keeping the previous behavior (NACK unconditionally) as default.

@roblaszczak roblaszczak merged commit bf0d239 into ThreeDotsLabs:master May 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants