Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the autogenerated topic name to conform with Azure limits #425

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

unjello
Copy link
Contributor

@unjello unjello commented Mar 5, 2024

Azure does only allow letters, digits and dash - (if not first, nor last) in the names of Storage Queues.

Closes #424

Azure does only allow letters, digits and dash `-` (if not first,
nor last) in the names of Storage Queues.

Closes ThreeDotsLabs#424
@m110
Copy link
Member

m110 commented Mar 5, 2024

Thanks @unjello!

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.73%. Comparing base (d20a605) to head (2660d2d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   76.69%   66.73%   -9.97%     
==========================================
  Files          57       63       +6     
  Lines        3012     4139    +1127     
==========================================
+ Hits         2310     2762     +452     
- Misses        563     1213     +650     
- Partials      139      164      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m110 m110 merged commit c0aecac into ThreeDotsLabs:master Mar 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated topic names for PubSub tests does not conform with Azure guidelines
2 participants