Recreate topology after reconnection #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m110 can you please review and approve this PR? |
|
I am also running into this issue where subscription is not re-established on reconnect. This fixes the issue. |
m110
reviewed
Jan 21, 2023
Comment on lines
+237
to
+240
| if err = s.prepareConsume(queueName, exchangeName, logFields); err != nil { | ||
| s.logger.Error("Failed to prepare consume", err, logFields) | ||
| return | ||
| } |
There was a problem hiding this comment.
@reva2 The issue here might be that you won't receive this error on the first subscriber run (it's just logged). Perhaps it makes sense to run s.prepareConsume in all these cases?
There was a problem hiding this comment.
Although that might cause duplicated logs so it's also not an elegant solution. 🤔
|
Any movement on this? I would very much love to see this feature. |
|
See #25 - the issue with this approach is that the initial error would not be returned, but only logged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ThreeDotsLabs/watermill#315