Delivery confirmation of published messages #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a flag to the publish config that turns on delivery confirmation. If set to true then the Publish function waits until a confirmation is received from the AMQP server to guarantee that the message is delivered. By default, delivery of published messages is not confirmed. Signed-off-by: Bob Stasyszyn <[email protected]>
fqutishat
approved these changes
May 8, 2022
sandrask
approved these changes
May 9, 2022
|
@roblaszczak @m110 This PR is ready for review. Thx. |
bstasyszyn
added a commit
to bstasyszyn/orb
that referenced
this pull request
May 10, 2022
When an AMQP server is restarted, the Orb pub-sub client receives a success response when publishing a message even though the message may not have been persisted by the AMQP server (because the server has died) and therefore the message is lost. This commit uses the latest version of watermill-amqp which adds a delivery confirmation feature. A failed delivery confirmation results in the message being retried (according to the pub-sub redelivery mechanism). A new startup parameter was added to enable/disable delivery confirmations. Delivery confirmations are enabled by default. (Note that the delivery confirmation pull request (ThreeDotsLabs/watermill-amqp#15) has not yet been merged, so this commit points to the TrustBloc fork of watermill-amqp. Once the PR is merged, Orb should be updated to point to the official library.) closes trustbloc#1290 Signed-off-by: Bob Stasyszyn <[email protected]>
bstasyszyn
added a commit
to bstasyszyn/orb
that referenced
this pull request
May 10, 2022
When an AMQP server is restarted, the Orb pub-sub client receives a success response when publishing a message even though the message may not have been persisted by the AMQP server (because the server has died) and therefore the message is lost. This commit uses the latest version of watermill-amqp which adds a delivery confirmation feature. A failed delivery confirmation results in the message being retried (according to the pub-sub redelivery mechanism). A new startup parameter was added to enable/disable delivery confirmations. Delivery confirmations are enabled by default. (Note that the delivery confirmation pull request (ThreeDotsLabs/watermill-amqp#15) has not yet been merged, so this commit points to the TrustBloc fork of watermill-amqp. Once the PR is merged, Orb should be updated to point to the official library.) Also: - Added a BDD test for AMQP server restart - Changed the onboarding-and-recovery BDD test to be run only for local CAS in order to reduce the time to run the integration tests closes trustbloc#1290 Signed-off-by: Bob Stasyszyn <[email protected]>
|
Thanks for another high-quality contribution @bstasyszyn! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a flag to the publish config that turns on delivery confirmation. If set to true then the Publish function waits until a confirmation is received from the AMQP server to guarantee that the message is delivered. By default, delivery of published messages is not confirmed.
Signed-off-by: Bob Stasyszyn [email protected]