cacheData in a BindingSeq should be re-calculated when re-watching the BindingSeq

[Atry]

Curious if I'm doing something wrong in this example code: https://scalafiddle.io/sf/HzKl1uG/4

If the checkbox is off, and I change the number, then when I click checkbox on, it doesn't reflect the number I've typed. But if dates are displayed, then changing the number has the proper effect.

Reported by @kahliburke on Gitter:
https://gitter.im/ThoughtWorksInc/Binding.scala?at=597958a6329651f46ec7752c

[Atry]

There should be a re-calculation of cacheData between line 888 and line 889

[Atry]

Another example written by @kahliburke : https://scalafiddle.io/sf/HX9dhMN/3

[Atry]

Since the cacheData should be re-calculated when watching, maybe it should be cleared when unwatching, in case of memory leaks.
https://github.com/ThoughtWorksInc/Binding.scala/blob/9513541/Binding/src/main/scala/com/thoughtworks/binding/Binding.scala#L878-L879

[Atry]

Also we can remove the initialization of cacheData as long as it will be computed when watching.

https://github.com/ThoughtWorksInc/Binding.scala/blob/9513541/Binding/src/main/scala/com/thoughtworks/binding/Binding.scala#L820-L824

[kahliburke]

I have tried some of the recommended changes which have not resolved the issue so far. While debugging it seemed that the use of a conditional was part of the issue, i.e.

@dom val elemDisplay = {
    if (show.bind)
      <div>{elems.bind}</div>
    else <!-- Nothing -->
  }

will show the issue while

@dom val elemDisplay = {
    val e = elems.bind
    if (show.bind)
      <div>{e}</div>
    else <!-- Nothing -->
  }

seems to work properly, with no other changes.

One thing I did notice that seems like a bug is that in FlatMapBinding.removePatchedListener there is a mistaken call for adding the patched listener to the children instead of removing it.

Binding.scala/Binding/src/main/scala/com/thoughtworks/binding/Binding.scala

Line 880 in 9513541

child.addPatchedListener(childListener)

[Atry]

Indeed. Mind sending a PR? 2017-08-10 3:20 GMT+08:00 Kahli Burke <[email protected]>:

…

I have tried some of the recommended changes which have not resolved the issue so far. While debugging it seemed that the use of a conditional was part of the issue, i.e. @dom val elemDisplay = { if (show.bind) <div>{elems.bind}</div> else <!-- Nothing --> } will show the issue while @dom val elemDisplay = { val e = elems.bind if (show.bind) <div>{e}</div> else <!-- Nothing --> } seems to work properly, with no other changes. One thing I did notice that seems like a bug is that in FlatMapBinding.removePatchedListener there is a mistaken call for adding the patched listener to the children instead of removing it. https://github.com/ThoughtWorksInc/Binding.scala/blob/ 9513541/Binding/src/main/ scala/com/thoughtworks/binding/Binding.scala#L880 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#56 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAktuiSIzeoeZGZ1oMAsxOPkgONJqU-nks5sWgZxgaJpZM4OmCYa> .

-- 杨博 (Yang Bo)

[kahliburke]

There already is one. :)