Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Send initial data stream when a client first requests it. #556

Merged
merged 2 commits into from
Feb 15, 2023
Merged

fix: Send initial data stream when a client first requests it. #556

merged 2 commits into from
Feb 15, 2023

Conversation

alexanderson1993
Copy link
Member

Description of Changes

  • Refactor how the data stream gets access to its inner context.
  • Call the sendDataStream function when a client first connects.

Related Issue

Closes #545

How do you know the changes work correctly?

Manual test:

  • Start a flight with the origin at Earth
  • Make sure the flight is paused, so no data stream messages are sent.
  • Go to the pilot card. The ship and planet should be positioned correctly and not right on top of each other.

@alexanderson1993 alexanderson1993 added this pull request to the merge queue Feb 15, 2023
auto-merge was automatically disabled February 15, 2023 00:55

Merge queue setting changed

@alexanderson1993 alexanderson1993 removed this pull request from the merge queue due to the queue being cleared Feb 15, 2023
@alexanderson1993 alexanderson1993 merged commit 2c562b8 into develop Feb 15, 2023
@alexanderson1993 alexanderson1993 deleted the initial-data-stream branch February 15, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send initial stream data when a client first requests stream data
1 participant
@alexanderson1993