Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Login): Add a Flight Director core for seeing which clients are logged in. #279

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

alexanderson1993
Copy link
Member

Description

Creates a definition for a Login core which can be used as a template for building other cores.

Related Issue

Closes #274

How do you know the changes work correctly?

Just a code review - there isn't any new functionality yet.

Types of changes

  • Docs Change (changes were only made to documentation)
  • Refactor (non-breaking change which improves code)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the built-in project documentation.
  • My change adds dependencies to this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexanderson1993 alexanderson1993 merged commit f9b3194 into develop Apr 22, 2022
@alexanderson1993 alexanderson1993 deleted the flight-director-core-definition branch April 22, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Flight Director - Determine how Flight Director controls (cores) are defined
1 participant