Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ship Map): Add deck creation and image upload. #238

Merged
merged 4 commits into from
Mar 13, 2022

Conversation

alexanderson1993
Copy link
Member

Description

Makes it possible to create new ship decks, reorder ship decks, and upload and remove ship deck images. Includes a pan-zoom view for the ship deck images too.

Related Issue

Closes #166.
Closes #171.

How do you know the changes work correctly?

Manual test

  • Go to the ship plugin config
  • Go to the "Ship Map" option
  • Create a deck
  • Create another deck
  • Reorder the decks by dragging between the decks
  • Upload an SVG image to one of the decks
  • Pan and zoom in the view.

Screenshots (if appropriate):

Screen Shot 2022-02-26 at 12 07 51 PM

Types of changes

  • Docs Change (changes were only made to documentation)
  • Refactor (non-breaking change which improves code)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the built-in project documentation.
  • My change adds dependencies to this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexanderson1993 alexanderson1993 merged commit 49e3d32 into develop Mar 13, 2022
@alexanderson1993 alexanderson1993 deleted the ship-map-frontend branch March 13, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship Map - in the config, support reordering decks Ship Map - Create frontend for uploading deck SVGs
1 participant