Skip to content

Commit

Permalink
Fix serverinfo overflow - reduce version cvar
Browse files Browse the repository at this point in the history
Mitigate the serverinfo overflow issue by reducing the version cvar
length which is somewhat longer than the official engine by 33 chars.

- Abbreviate PRODUCT_NAME to match official (will affect pid filenames)
- Remove redundant product name from makeFile VERSION
- Reduce git info to rev alone (commit date can be inferred from hash)

Mitigates mickael9#30
  • Loading branch information
ThomasBrierley committed Apr 9, 2018
1 parent 1010cc3 commit 4fa5cdc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ endif
export CROSS_COMPILING

ifndef VERSION
VERSION=ioq3urt-mickael9
VERSION=m9
endif

ifndef CLIENTBIN
Expand Down Expand Up @@ -288,9 +288,9 @@ endif
# Add git version info
USE_GIT=
ifeq ($(wildcard .git),.git)
GIT_REV=$(shell git show -s --pretty=format:%h-%ad --date=short)
GIT_REV=$(shell git describe --always)
ifneq ($(GIT_REV),)
VERSION:=$(VERSION)_GIT_$(GIT_REV)
VERSION:=$(VERSION)-$(GIT_REV)
USE_GIT=1
endif
endif
Expand Down
2 changes: 1 addition & 1 deletion code/qcommon/q_shared.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
// q_shared.h -- included first by ALL program modules.
// A user mod should never modify this file

#define PRODUCT_NAME "ioQuake3-UrT"
#define PRODUCT_NAME "ioQ3-UrT"
#define BASEGAME "q3ut4"
#define CLIENT_WINDOW_TITLE "UrbanTerror"
#define CLIENT_WINDOW_MIN_TITLE "UrbanTerror"
Expand Down

0 comments on commit 4fa5cdc

Please sign in to comment.