Attempt #2 with render complete

ThomThomson · Oct 28, 2021 · d9c5348 · d9c5348
1 parent 27ae3de
commit d9c5348
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/examples/embeddable_examples/public/hello_world/hello_world_embeddable.tsx b/examples/embeddable_examples/public/hello_world/hello_world_embeddable.tsx
@@ -33,7 +33,8 @@ export class HelloWorldEmbeddable extends Embeddable {
    * @param node
    */
   public render(node: HTMLElement) {
-    node.innerHTML = '<div data-test-subj="helloWorldEmbeddable">HELLO WORLD!</div>';
+    node.innerHTML =
+      '<div data-test-subj="helloWorldEmbeddable" data-render-complete="true">HELLO WORLD!</div>';
   }
 
   /**

diff --git a/examples/embeddable_examples/public/todo/todo_component.tsx b/examples/embeddable_examples/public/todo/todo_component.tsx
@@ -41,7 +41,7 @@ function wrapSearchTerms(task: string, search?: string) {
 
 export function TodoEmbeddableComponentInner({ input: { icon, title, task, search } }: Props) {
   return (
-    <EuiFlexGroup gutterSize="none">
+    <EuiFlexGroup gutterSize="none" data-render-complete="true">
       <EuiFlexItem grow={false}>
         {icon ? <EuiIcon type={icon} size="l" /> : <EuiAvatar name={title || task} size="l" />}
       </EuiFlexItem>

diff --git a/examples/embeddable_examples/public/todo/todo_ref_component.tsx b/examples/embeddable_examples/public/todo/todo_ref_component.tsx
@@ -45,7 +45,7 @@ export function TodoRefEmbeddableComponentInner({
   const title = savedAttributes?.title;
   const task = savedAttributes?.task;
   return (
-    <EuiFlexGroup>
+    <EuiFlexGroup data-render-complete="true">
       <EuiFlexItem grow={false}>
         {icon ? (
           <EuiIcon type={icon} size="l" />

diff --git a/test/examples/embeddables/dashboard.ts b/test/examples/embeddables/dashboard.ts
@@ -97,7 +97,7 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide
   const pieChart = getService('pieChart');
   const dashboardExpect = getService('dashboardExpect');
   const elasticChart = getService('elasticChart');
-  const PageObjects = getPageObjects(['common', 'visChart', 'header']);
+  const PageObjects = getPageObjects(['common', 'visChart', 'dashboard']);
   const monacoEditor = getService('monacoEditor');
 
   describe.only('dashboard container', () => {
@@ -108,7 +108,7 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide
       );
       await PageObjects.common.navigateToApp('dashboardEmbeddableExamples');
       await testSubjects.click('dashboardEmbeddableByValue');
-      await PageObjects.header.waitUntilLoadingHasFinished();
+      await PageObjects.dashboard.waitForRenderComplete();
 
       await updateInput(JSON.stringify(testDashboardInput, null, 4));
     });