Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design patient registry #377

Merged
merged 6 commits into from
May 4, 2016
Merged

Design patient registry #377

merged 6 commits into from
May 4, 2016

Conversation

lomamech
Copy link
Collaborator

@lomamech lomamech commented May 3, 2016

  • Adding unit patient search and showing the data in a UI GRID
  • Adding test E2E for research patient
  • Update some test E2E

@jniles

@lomamech
Adding unit patient search and showing the data in a UI GRID
1fa0596
@lomamech
Adding test E2E for research patient
3654fff
@lomamech
Improving the test E2E for Patient Registry and Adding an ID on the U…
90c4c8d 
…I GRID for Patients Registries
@lomamech
Update some test E2E
308fefc 
Update the condition of comparaison for billing service and debtors groups
update the rank for the deletion for the unit subsidy
jniles
jniles reviewed May 4, 2016
View reviewed changes
client/src/i18n/fr.json
"MONTHS" : "mois",
"YEAR_OLD" : "an",
"YEARS_OLD" : "ans",
"PAGE_TITLE" : "Recherche des patients"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalement, nous appelons cette clé "TITLE".

@jniles
Copy link
Collaborator

jniles commented May 4, 2016

@lomamech, je viens de terminer un examen préliminaire.

Your tests are very good! The module has clean code, and looks like the module requested in #336.

Here are the fixes that need to take place before this lands in master:

  1. There is a small bug with the BUID() usage in medical/patient.js. This must be fixed.
  2. The comments are from the "Users and Permissions" module, which is confusing. Please either update them (preferable) or remove them.
  3. We removed getAge() in favor of angular-moment, which is already translated into French. Please attempt to show the age with angular-moment - I think @sfount has suggested some sample code and can help further if you need it. He has experience working with ages on patient cards.
  4. If there isn't a Patients.read() method, it should be created and used instead of Patients.detail(). Patients.detail() was only meant to return a single patient.

After these fixes, I'll run the tests on my local machine and merge into master. Thanks!

@lomamech
Improve patient registry
f1fef1c 
Update translate files
Using patient registry instead patient search
Remove method getDate instead the using of angular-moment
Fix some comment
@lomamech
Complete translate liste
82dae7d
@lomamech
Copy link
Collaborator Author

lomamech commented May 4, 2016

  • Improve patient registry
  • Complete translate liste

@jniles

jniles
jniles reviewed May 4, 2016
View reviewed changes
client/src/js/app.js
.state('/patients/search/:patientID?', {
controller: 'patientRecords',
templateUrl: '/partials/patients/search/search.html'
.state('/patients/registry/', {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parfait!

@jniles
Copy link
Collaborator

jniles commented May 4, 2016

LGTM!

@jniles jniles merged commit 33e8148 into Third-Culture-Software:master May 4, 2016
@jniles
Copy link
Collaborator

jniles commented May 4, 2016

References #336.

@lomamech lomamech deleted the designPatientRegistry branch May 15, 2017 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lomamech @jniles @sfount