fix(journal): preserve trans_id_reference_number #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
We now remember the trans_id_reference_number when we create new lines in a transaction. This means we no longer error when trying to add new lines to a transaction. Note that we still need to add a test. Partially addresses Third-Culture-Software#3536.
jniles
force-pushed
the
fix-journal-insert-new-line-bug-in-edit-transaction
branch
from
f7718bf
to
c0d4c31
Compare
|
bors r+ |
1 similar comment
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 10, 2019
3530: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.120.1` to `1.121.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v1.121.0</summary> <h1><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.120.1...v1.121.0">1.121.0</a> (2019-01-08)</h1> <h3>Features</h3> <ul> <li>Split dockerfile / base image vulns (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530d">b2f530d</a>)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 4 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/ecac358cc1da7cee3715e709cfa368838c598af6"><code>ecac358</code></a> <code>Merge pull request #313 from snyk/feat/docker-split-user-base-vulns</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/b2f530db922c85eed0de6139512e6eb83cb174fa"><code>b2f530d</code></a> <code>feat: Split dockerfile / base image vulns</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/5f6083bb2f4dd80ecd7a3f4f7c8a16aa00f7eb58"><code>5f6083b</code></a> <code>Merge pull request #321 from snyk/chore/disable-lockfile-creation</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/95be92c862655fdda539056893336c4eb05582e3"><code>95be92c</code></a> <code>chore: Disable lockfile creation</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/5938f576c782762d1cbaa9cd4d10afa7dde3b91b...ecac358cc1da7cee3715e709cfa368838c598af6">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 3537: fix(journal): preserve trans_id_reference_number r=jniles a=jniles We now remember the trans_id_reference_number when we create new lines in a transaction. This means we no longer error when trying to add new lines to a transaction. Note that we still need to add a test. Partially addresses #3536. Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Jonathan Niles <[email protected]>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jan 10, 2019
3537: fix(journal): preserve trans_id_reference_number r=jniles a=jniles We now remember the trans_id_reference_number when we create new lines in a transaction. This means we no longer error when trying to add new lines to a transaction. Note that we still need to add a test. Partially addresses #3536. Co-authored-by: Jonathan Niles <[email protected]>
Build succeeded |
jniles
deleted the
fix-journal-insert-new-line-bug-in-edit-transaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now remember the trans_id_reference_number when we create new lines in a transaction. This means we no longer error when trying to add new lines to a transaction.
Note that we still need to add a test.
Partially addresses #3536.