refractor(session service) using $state instead of $location #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the SessionService tests need to be updated before this will pass. Could you take look at them? |
jeremielodi
force-pushed
the
sesion_service_refractor
branch
2 times, most recently
from
ac66844
to
b00c07f
Compare
jeremielodi
force-pushed
the
sesion_service_refractor
branch
4 times, most recently
from
332fdc3
to
d991d34
Compare
jniles
approved these changes
Aug 30, 2018
bors bot
added a commit
that referenced
this pull request
Aug 30, 2018
3041: refractor(session service) using $state instead of $location r=jniles a=jeremielodi closes #3030 3094: fix: migrate to utf8mb4 r=jniles a=jniles This commit migrates the database to UTF8MB4 in preparation for MySQL 8 which defaults to this. It also produces better results for diverse character sets. Closes #2989. **Overview** The motivation for this Pull Request is two-fold: 1. Make sure no one had [break the server](https://medium.com/@adamhooper/in-mysql-never-use-utf8-use-utf8mb4-11761243e434) by putting valid characters that [cannot be represented in MySQL's UTF8 character set](https://stackoverflow.com/questions/30074492/what-is-the-difference-between-utf8mb4-and-utf8-charsets-in-mysql#30074553). 2. Ensure we are set up for future releases of MySQL and future languages by migrating to UTF8MB4. MySQL 8 will support this out of the box. And additional benefit continues the work started by @mbayopanda in his work on Travis CI changes in #3061 to document and standardize the character sets and collations in our database. Previously, we just relied on having "the right set up", with some of our Stored Procedures in the server's default encoding, functions called in the mysqljs's default encoding, etc... Now, we define at creation time and connection time the character sets and collations we are working with. **Notes** I had to [skip one test](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/test/end-to-end/verificationLinks/verificationLinks.spec.js#L19). It was the link between debtor groups and patients. I'm pretty sure this is due to the fact that the order data was inserted in changed somehow. Either way, the test is non-specific and should be re-written to reference the group by its name. Co-authored-by: jeremielodi <[email protected]> Co-authored-by: Jonathan Niles <[email protected]>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Aug 30, 2018
3041: refractor(session service) using $state instead of $location r=jniles a=jeremielodi closes #3030 Co-authored-by: jeremielodi <[email protected]>
Build failed |
|
@jeremielodi, looks like the most recent changes to the master branch have broken these tests. Can you try to resolve these? |
|
ok, let me give it a try |
jeremielodi
force-pushed
the
sesion_service_refractor
branch
from
d991d34
to
a242d58
Compare
jeremielodi
force-pushed
the
sesion_service_refractor
branch
from
a242d58
to
f670c25
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2018
3041: refractor(session service) using $state instead of $location r=jniles a=jeremielodi closes #3030 Co-authored-by: jeremielodi <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3030