fix(cashboxes): display all cashboxes in selection #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows a user to select any project's cashbox from the cashbox selection page. As designed, BHIMA assumes that users will have separate projects and use their own cashboxes, so those are cleanly separated from the remaining cashboxes. However, it does give the user the possibility of using any registered cashbox. Closes Third-Culture-Software#1976.
jniles
force-pushed
the
fix-cash-window-load-all-cashboxes
branch
from
3387e72
to
f2caea4
Compare
sfount
approved these changes
Aug 28, 2017
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 28, 2017
2036: fix(cashboxes): display all cashboxes in selection r=sfount a=jniles This commit allows a user to select any project's cashbox from the cashbox selection page. As designed, BHIMA assumes that users will have separate projects and use their own cashboxes, so those are cleanly separated from the remaining cashboxes. However, it does give the user the possibility of using any registered cashbox. Closes #1976.
|
bors r+ |
|
Not awaiting review |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows a user to select any project's cashbox from the
cashbox selection page. As designed, BHIMA assumes that users will have
separate projects and use their own cashboxes, so those are cleanly
separated from the remaining cashboxes. However, it does give the user
the possibility of using any registered cashbox.
Closes #1976.