Remove the deprecated filter into patient registry #1969
Conversation
DedrickEnc
force-pushed
the
filterDeprecated
branch
from
6ab85eb
to
7417817
Compare
There was a problem hiding this comment.
@DedrickEnc, this look pretty good!
There are a couple small changes to make - the links from other registries are broken here, but in general the code is well written.
| @@ -62,8 +62,9 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div class="flex-util bh-filter-bar"> | |||
| <div class="flex-util" style="min-height : 35px; padding-top : 7px; max-height: initial"> | |||
There was a problem hiding this comment.
I don't think these styles should have been updated - was there a reason?
| @@ -193,15 +185,6 @@ function PatientRegistryController($state, Patients, Notify, AppCache, | |||
|
|
|||
| // startup function. Checks for cached filters and loads them. This behavior could be changed. | |||
| function startup() { | |||
|
|
|||
| if ($state.params.filters) { | |||
There was a problem hiding this comment.
You still need to do something like this -- it will break the links from the Payments and Invoice Registries into the Patient Registry.
I suggest you implement something like #1935 to solve this.
| @@ -15,94 +15,90 @@ | |||
| <uib-tabset> | |||
| <uib-tab index="0" heading="{{ 'FORM.LABELS.SEARCH_QUERRIES' | translate }}" data-custom-filter-tab> | |||
| <div class="tab-body"> | |||
| <div class="form-group" ng-class="{ 'has-error' : ModalForm.$submitted && ModalForm.name.$invalid }"> | |||
| .then(function (result) { | ||
| vm.patientGroups = result; | ||
| }); | ||
| vm.onSelectPatientGroup = function onSelectPatientGroup(patientGroup) { |
There was a problem hiding this comment.
This is a nice improvement 👍
|
|
||
| $ctrl.$onInit = function onInit() { | ||
| // fired when a patient group has been selected | ||
| $ctrl.onSelectCallback = $ctrl.onSelectCallback || angular.noop; |
There was a problem hiding this comment.
Since this is required, you don't actually need to instantiate it - angular will default to angular.noop if it is not defined.
| PatientGroups.read() | ||
| .then(function (pgs) { | ||
| $ctrl.patientGroups = pgs; | ||
| }); |
There was a problem hiding this comment.
This should have a .catch() method.
sfount
changed the title
DedrickEnc
force-pushed
the
filterDeprecated
branch
4 times, most recently
from
d44ddb4
to
fed4ff6
Compare
DedrickEnc
force-pushed
the
filterDeprecated
branch
from
fed4ff6
to
ad90506
Compare
|
@jniles |
|
Looks good to me. |
|
bors r+ |
1969: Remove the deprecated filter into patient registry r=jniles In this PR : - The deprecated filter is removed from the patient registry file, - The search modal was also updated to follow the new standard - A new component was implemented ```bhPatientGroupSelect``` and its test This PR references #1942
Build succeeded |
In this PR :
The deprecated filter is removed from the patient registry file,
The search modal was also updated to follow the new standard
A new component was implemented
bhPatientGroupSelectand its testThis PR references #1942
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the online review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!