Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) improvements to the Inventory Groups Page #993

Closed
jniles opened this issue Nov 30, 2016 · 0 comments · Fixed by #1867
Closed

(refactor) improvements to the Inventory Groups Page #993

jniles opened this issue Nov 30, 2016 · 0 comments · Fixed by #1867
Labels
Refactor

Comments

@jniles
Copy link
Collaborator

jniles commented Nov 30, 2016

The following are improvements that could be made to the Inventory Groups page:

  1. The account ui-select does not order accounts properly. It should order them based on the accounts tree ordering.
  2. There is no way to print each inventory group out. There should be an inventory group report.
  3. All create and edit buttons should have both text and icons. There is a confusing mixture on the current page.
  4. Canceling an edit or add modal on the inventory groups page throws a JS error.
  5. The modals should use headercrumbs
  6. The entire page should use $state-based routing.
@jniles jniles added this to the Inventory Management Implementation milestone Nov 30, 2016
@jniles jniles mentioned this issue Jul 17, 2017
Merged
bors bot added a commit that referenced this issue Jul 18, 2017
@bors
Merge #1866 #1867 #1874
c7f645c 
1866: feat(patients): accept any document upload r=jniles

This commit allows any document to be uploaded and attached to a
patient.  It also updates the document upload modal with the latest
header crumb and translate directives.

Closes #1823

1867: Fix: ui select option rendering r=jniles

For some reason, a `ui-select` can only have a single `<span>` element within due to a miscreated CSS selector in the bootstrap css theme.  Otherwise, the text is not labeled on the same line and is misaligned.  This PR fixes those issues in the prices.html file and the inventory management page.

It also uses the `translate` directive where applicable.

Closes #993.  Closes #1720.

1874: fix: allow navigation to settings after 403 error r=jniles

This commit fixes a small bug does not a user log out after they have
hit the 403 state.

Closes #1862.
@bors bors bot closed this as completed in #1867 Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: ui select option rendering jniles/bhima
1 participant
@jniles