Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters not updating displayValues on multiple searches #2595

Closed
jniles opened this issue Mar 9, 2018 · 0 comments · Fixed by #2614
Closed

Filters not updating displayValues on multiple searches #2595

jniles opened this issue Mar 9, 2018 · 0 comments · Fixed by #2614
Assignees
@jeremielodi
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Mar 9, 2018

It looks like most filters in the filterbar are not updating their values when the value has been set, then changed. For example:

  1. Go to the Patient Registry.
  2. Search for "bob". The filter will be set to "bob".
  3. Search for "jane". The module will load "jane", but the display value will still be "bob"

This affects most modules I have tested.
@jniles jniles added the Bug label Mar 9, 2018
@jeremielodi jeremielodi self-assigned this Mar 23, 2018
@jeremielodi jeremielodi mentioned this issue Mar 23, 2018
Merged
bors bot added a commit that referenced this issue Mar 23, 2018
@bors
Merge #2614
ac1af4f 
2614: feat(patient registry) update filters displayValues on multiple searches r=jniles a=jeremielodi

closes #2595
bors bot added a commit that referenced this issue Mar 23, 2018
@bors
Merge #2614
ac01a87 
2614: feat(patient registry) update filters displayValues on multiple searches r=jniles a=jeremielodi

closes #2595
@bors bors bot closed this as completed in #2614 Mar 23, 2018
jniles added a commit to jniles/bhima that referenced this issue Mar 26, 2018
@jniles
fix: correct filter display values
209ee86 
The search filters must update their display values if the underlying
value changes.  Previously, the default case was to preserve display
values, but it didn't take into account the changes in the underlying
value, leading to display values being out of sync with the values.

This was reported in Third-Culture-Software#2595.
jniles added a commit to jniles/bhima that referenced this issue Mar 26, 2018
@jniles
fix: correct filter display values
826d729 
The search filters must update their display values if the underlying
value changes.  Previously, the default case was to preserve display
values, but it didn't take into account the changes in the underlying
value, leading to display values being out of sync with the values.

This was reported in Third-Culture-Software#2595.
@jniles jniles mentioned this issue Mar 26, 2018
Merged
bors bot added a commit that referenced this issue Mar 26, 2018
@bors
Merge #2616
3d8cc58 
2616: fix: correct filter display values r=jniles a=jniles

The search filters must update their display values if the underlying value changes.  Previously, the default case was to preserve display values, but it didn't take into account the changes in the underlying value, leading to display values being out of sync with the values.

This was reported in #2595.
@jniles jniles mentioned this issue Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremielodi jeremielodi

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(patient registry) update filters displayValues on multiple searches jeremielodi/bhima-2.X
2 participants
@jniles @jeremielodi