Skip to content

Commit

Permalink
fix(report): balance report UI fixes
Browse files Browse the repository at this point in the history
This commit fixes some broken translation on the balance report modal as
well as invalid HTML.
  • Loading branch information
Jonathan Niles authored and sfount committed Feb 23, 2017
1 parent 5446129 commit 518e586
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions client/src/partials/reports/modals/balance.modal.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<form name="ConfigForm" bh-submit="ReportConfigCtrl.generate(ConfigForm)" bh-form-defaults novalidate autocomplete="off">
<div class="modal-header">
<ol class="headercrumb">
<li class="static" translate>ReportConfigCtrl.report.title_key</li>
<li class="static" translate>{{ReportConfigCtrl.report.title_key}}</li>
<li class="title" translate>FORM.LABELS.CREATE</li>
</ol>
</div>
Expand All @@ -28,7 +28,7 @@
theme="bootstrap"
required>
<ui-select-match placeholder="{{ 'FORM.PLACEHOLDERS.ACCOUNT' | translate }}">
<span>{{$select.selected.number}}</span> - <span translate>$select.selected.name</span>
<span>{{$select.selected.number}}</span> - <span translate>{{ $select.selected.name }}</span>
</ui-select-match>
<ui-select-choices ui-select-focus-patch repeat="c in ReportConfigCtrl.classes | filter:$select.search">
<span ng-bind-html="c.number | highlight:$select.search"></span> -
Expand Down Expand Up @@ -72,7 +72,7 @@
<input type="radio" ng-model="ReportConfigCtrl.dateOption" ng-value="'date-until'">
<span translate>BALANCE.DATE_UNTIL</span>
</label>
</fieldset>
</div>

<!-- choose date interval -->
<div ng-if="ReportConfigCtrl.dateOption === 'date-range'">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<th rowspan="2" class="text-center">{{translate "ACCOUNT.NUMBER" }}</th>
<th rowspan="2" class="text-center">{{translate "FORM.LABELS.ACCOUNT" }}</th>
<th colspan="2" class="text-center">
{{translate "BALANCE.OLD_SOLD" }} <br>
{{translate "BALANCE.OLD_SOLD" }} <br>
<small>{{#if session.date}}< {{date session.date "MMMM"}}{{/if}}</small>
<small>{{#if session.dateTo}}< {{date session.dateTo "MMMM"}}{{/if}}</small>
</th>
Expand Down

0 comments on commit 518e586

Please sign in to comment.