Update dependencies including project Go version #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamjoemccormick
added
dependencies
iamjoemccormick
force-pushed
the
iamjoemccormick/dependency-updates
branch
2 times, most recently
from
0b1789e
to
48647f6
Compare
iamjoemccormick
force-pushed
the
iamjoemccormick/dependency-updates
branch
3 times, most recently
from
69cf137
to
8ae1515
Compare
Notable changes: - Updated to Go 1.22. - K8s e2e tests now use a context from Ginkgo (kubernetes/kubernetes@2f6c4f5). Added TODO contexts where needed for now. - Various "Expect" functions were removed from the e2e framework. Replaced with equivalent conditionals and calls to Failf as suggested by (https://www.kubernetes.dev/blog/2023/04/12/e2e-testing-best-practices-reloaded/). - Fixed operator tests broken by the need to upgrade the controller-runtime pkg to work with the latest k8s.io/client-go pkg. Rationale on fixes to e2e tests: Despite not currently running e2e tests, it is better not to leave these broken as it will be harder to fix them in the future without the immediate context of what dependencies changed.
- Ensure Git doesn't ever ignore anything under vendor/.
Due to the previous dependency updates, the old version was no longer compatible and would panic when trying to generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
iamjoemccormick
force-pushed
the
iamjoemccormick/dependency-updates
branch
from
8ae1515
to
beb5199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging:
go.modor equivalent been updated to point at a version that contains the related changes?Which issue(s) does this PR address?
None (prompted by Dependabot Alerts).
Does this PR depend on any other PRs to be merged first?
None
What does this PR do / why do we need it?
Update various test dependencies to address various security vulnerabilities.
Notable changes:
Rationale on fixes to e2e tests:
Despite not currently running e2e tests, it is better not to leave these broken as it will be harder to fix them in the future without the immediate context of what dependencies changed.
Where should the reviewer(s) start reviewing this?
Changes in
go.modand then the miscellaneous changes undertest/e2eandoperator/.Are there any specific topics we should discuss before merging?
None
What are the next steps after this PR?
Update e2e-tests matrix to support new K8s and BeeGFS versions ahead of the next release.