Return error instead of invalid JSON if response too large

[martinjaeger]

With more data nodes than the buffer can fit, we got following ThingSet response:

Received Request (5 bytes): ?conf
:85 Content. { ... ,"Credit":0,"CustomMessage"}

ThingSet should always answer with valid JSON or an error message.

This commit fixes the issue. Now we get:

Received Request (5 bytes): ?conf
:E1 Response too large.

[JordanSilverman]

Strictly speaking this is good. However, I quite liked the previous characteristic where is would strip out the JSON value which is too large and still display the rest of the data. It was really useful in the case where I had a large buffer as a thingset object and when the buffer gets too full, I can still see the rest of the data in that category.

I'll approve anyway because I suppose this is the proper behaviour.

[azeemshatp]

LGTM. Thanks

[martinjaeger]

Strictly speaking this is good. However, I quite liked the previous characteristic where is would strip out the JSON value which is too large and still display the rest of the data. It was really useful in the case where I had a large buffer as a thingset object and when the buffer gets too full, I can still see the rest of the data in that category.

Unfortunately it didn't always strip out the entire JSON key/value pair, but sometimes only the value. This has to be avoided, I think. But we could think about a new error code "partial response" (not sure if this should be considered an error or a success though).

I suggest to merge and open an enhancement issue for the partial success return code.