Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added element data module #61

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Added element data module #61

merged 8 commits into from
Nov 13, 2023

Conversation

YHordijk
Copy link
Contributor

@YHordijk YHordijk commented Nov 9, 2023

Element data module contains colors and radii of all atoms with an easy to use interface.

@YHordijk YHordijk self-assigned this Nov 9, 2023
@YHordijk YHordijk linked an issue Nov 9, 2023 that may be closed by this pull request
Element data module #57
Closed
SiebeLeDe
SiebeLeDe reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@SiebeLeDe SiebeLeDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment about rewriting atom_data.py with pathlib instead of using os

TCutility/atom_data.py Show resolved Hide resolved
@YHordijk YHordijk requested a review from SiebeLeDe November 9, 2023 15:06
SiebeLeDe
SiebeLeDe reviewed Nov 11, 2023
View reviewed changes
Copy link
Contributor

@SiebeLeDe SiebeLeDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of pathlib!

@SiebeLeDe SiebeLeDe merged commit e52280a into main Nov 13, 2023
6 checks passed
@SiebeLeDe SiebeLeDe deleted the element-data-module branch November 13, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebeLeDe SiebeLeDe SiebeLeDe left review comments

@SEBeutick SEBeutick Awaiting requested review from SEBeutick

Assignees

@YHordijk YHordijk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element data module
2 participants
@YHordijk @SiebeLeDe